Add global boolean for controlling whether to record concrete shapes or not #101043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101043
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4f1fcbb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
davidberard98
force-pushed
the
export-D45680162
branch
from
023ffab
to
643ed13
Compare
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 10, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: f13fed41b019031532dec2a9eaa92f653a706192
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 10, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: a5d6c07a441e8a1f557f6a6a4814c120a01b0a8a
davidberard98
force-pushed
the
export-D45680162
branch
from
643ed13
to
9075f59
Compare
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 10, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: cba2d90dc1d3dd061078a523e17144aa0eba547c
davidberard98
force-pushed
the
export-D45680162
branch
from
9075f59
to
1938122
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 10, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: e37b03ea6cf7be68628511b7e9b9d7c395ed4a50
davidberard98
force-pushed
the
export-D45680162
branch
from
1938122
to
aee2059
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 11, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: 680780ad9c947c0c60d09b3ba9904490730e96cb
davidberard98
force-pushed
the
export-D45680162
branch
from
aee2059
to
776908b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
davidberard98
added a commit
to davidberard98/pytorch
that referenced
this pull request
May 11, 2023
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: 84c831baa9f024321d9afee74210dfe18a96f163
davidberard98
force-pushed
the
export-D45680162
branch
from
776908b
to
ea2ef9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: ef2bc60bc688db8143a82c8423d14b20b3a58155
davidberard98
force-pushed
the
export-D45680162
branch
from
ea2ef9c
to
4f1fcbb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45680162 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact.
Test Plan:
Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to
pytorch/kineto:pytorch_record_concrete_inputs; before, it returns true; after, it returns false.Note that D45681838 had to add
serviceon the main function. That's because we need toinitFacebookin order to use jks.Differential Revision: D45680162