Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global boolean for controlling whether to record concrete shapes or not #101043

Closed
wants to merge 1 commit into from
Closed

Add global boolean for controlling whether to record concrete shapes or not #101043

wants to merge 1 commit into from

Commits on May 11, 2023

  1. Add global boolean for controlling whether to record concrete shapes … 

    …or not (pytorch#101043)

Summary:
Pull Request resolved: pytorch#101043

We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact.

Test Plan:
Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false.

Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks.

Reviewed By: aaronenyeshi

Differential Revision: D45680162

fbshipit-source-id: ef2bc60bc688db8143a82c8423d14b20b3a58155
    @davidberard98 @facebook-github-bot
    davidberard98 authored and facebook-github-bot committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4f1fcbb View commit details
    Browse the repository at this point in the history