SymIntify functorch vmap #101409
Closed
SymIntify functorch vmap #101409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101409
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 49d6afd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
Skylion007
reviewed
May 15, 2023
Skylion007
reviewed
May 15, 2023
Skylion007
reviewed
May 15, 2023
Skylion007
approved these changes
May 15, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Skylion007
approved these changes
May 15, 2023
zou3519
approved these changes
May 15, 2023
zou3519
added a commit
that referenced
this pull request
May 16, 2023
The UB was: - We grab a reference to the last element in the interpreter stack (DynamicLayerStack) - Then, we pop the last element in the interpreter stack - Finally, we continue to use the reference to the last element. The fix is to stop using that reference and instead use the popped element. Test Plan: - It's difficult to write a test for this PR so I didn't - Patched in #101409 and verified that this PR fixes the bad_variant_access it was experiencing under clang compilers. [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
May 16, 2023
The UB was: - We grab a reference to the last element in the interpreter stack (DynamicLayerStack) - Then, we pop the last element in the interpreter stack - Finally, we continue to use the reference to the last element. The fix is to stop using that reference and instead use the popped element. Test Plan: - It's difficult to write a test for this PR so I didn't - Patched in #101409 and verified that this PR fixes the bad_variant_access it was experiencing under clang compilers. ghstack-source-id: d1f7bd3f68aac7aadcef13e7fff004af81f6a185 Pull Request resolved: #101568
pytorchmergebot
pushed a commit
that referenced
this pull request
May 17, 2023
The UB was: - We grab a reference to the last element in the interpreter stack (DynamicLayerStack) - Then, we pop the last element in the interpreter stack - Finally, we continue to use the reference to the last element. The fix is to stop using that reference and instead use the popped element. Test Plan: - It's difficult to write a test for this PR so I didn't - Patched in #101409 and verified that this PR fixes the bad_variant_access it was experiencing under clang compilers. Pull Request resolved: #101568 Approved by: https://github.com/ezyang, https://github.com/Skylion007
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "doesn't look failing to me" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jcaip
pushed a commit
that referenced
this pull request
May 23, 2023
The UB was: - We grab a reference to the last element in the interpreter stack (DynamicLayerStack) - Then, we pop the last element in the interpreter stack - Finally, we continue to use the reference to the last element. The fix is to stop using that reference and instead use the popped element. Test Plan: - It's difficult to write a test for this PR so I didn't - Patched in #101409 and verified that this PR fixes the bad_variant_access it was experiencing under clang compilers. Pull Request resolved: #101568 Approved by: https://github.com/ezyang, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com