Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Support aten::scatter_reduce #102048

Closed
wants to merge 10 commits into from

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented May 23, 2023

Stack from ghstack (oldest at bottom):

Fixes #84260

reduce='mean' is not supported, as it's not in ONNX spec (onnx/onnx#5100)

@pytorch-bot
Copy link

pytorch-bot bot commented May 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102048

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c61b247:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 23, 2023
@titaiwangms titaiwangms marked this pull request as draft May 23, 2023 04:35
titaiwangms added a commit that referenced this pull request May 23, 2023
ghstack-source-id: fdaf45bcc4bda39d2d2a3f38739ba1d629037358
Pull Request resolved: #102048
@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: new features topic category labels May 23, 2023
titaiwangms added a commit that referenced this pull request May 23, 2023
ghstack-source-id: a6e3ce7b100628ff4cb2d5962ff61703d1793da5
Pull Request resolved: #102048
titaiwangms added a commit that referenced this pull request May 23, 2023
ghstack-source-id: 33d3b64c9deb6237e50bf66ed913d0a43bf8e919
Pull Request resolved: #102048
@titaiwangms titaiwangms marked this pull request as ready for review May 25, 2023 00:52
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: 80d9fd756f7554b27d76b1ad1f6cede7b218b92f
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: d4f245eedaa9434786e0d8f4ab3269b3798bcd51
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: 42d8855664af59b19b006ddb6c2d9b3be4ebdd6e
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: 00ab1d1bc227fed547d0f88854b517a76572debf
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: 57201a320b50443ee9e4a16e8b0a4a2c68e3439f
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: 29ee31e926e45bd5a2c491e01809df465582bda8
Pull Request resolved: #102048
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
titaiwangms added a commit that referenced this pull request May 25, 2023
ghstack-source-id: ead7224dc82854156803af737080618cd3251fbe
Pull Request resolved: #102048
@titaiwangms titaiwangms added the ciflow/trunk Trigger trunk jobs on your pull request label May 25, 2023
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/titaiwangms/21/head branch June 8, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants