Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo] fix module buffers call #102251

Closed
wants to merge 2 commits into from
Closed

[dynamo] fix module buffers call #102251

wants to merge 2 commits into from

Conversation

wanchaol
Copy link
Contributor

@wanchaol wanchaol commented May 25, 2023 •
edited by pytorch-bot bot

@wanchaol
[dynamo] fix module buffers call
1cc50f2 
This PR fixes module buffers call and extract module.buffers similar to
module.parameters

[ghstack-poisoned]
@wanchaol wanchaol mentioned this pull request May 25, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 25, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102251

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 381ea73:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wanchaol added a commit that referenced this pull request May 25, 2023
@wanchaol
[dynamo] fix module buffers call
cfafe17 
This PR fixes module buffers call and extract module.buffers similar to
module.parameters

ghstack-source-id: cf9bde114272d9190140e30293f7a8db0a378c9c
Pull Request resolved: #102251
@wanchaol
Update on "[dynamo] fix module buffers call"
381ea73 
This PR fixes module buffers call and extract module.buffers similar to
module.parameters

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
wanchaol added a commit that referenced this pull request May 25, 2023
@wanchaol
[dynamo] fix module buffers call
e23bef4 
This PR fixes module buffers call and extract module.buffers similar to
module.parameters

ghstack-source-id: a9d9409697ad71b3188eaa8ebc5ba6f1cb320eb9
Pull Request resolved: #102251
@wanchaol
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 25, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@wanchaol
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@wanchaol
Copy link
Contributor Author

@pytorchbot merge -f "failure not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/318/head branch June 8, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wconstab wconstab wconstab approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wanchaol @pytorchmergebot @wconstab