Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamo] fix module buffers call #102251

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/dynamo/test_modules.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Owner(s): ["module: dynamo"]

import collections
import itertools
import traceback
import types
import unittest
Expand Down Expand Up @@ -1386,6 +1387,16 @@ def forward(self, x):
# Check parameteres and buffers
for p1, p2 in zip(mod.parameters(), opt_mod.parameters()):
self.assertTrue(id(p1) == id(p2))
for b1, b2 in zip(mod.buffers(), opt_mod.buffers()):
self.assertTrue(id(b1) == id(b2))

def get_parameter_dtype(mod: torch.nn.Module):
parameters_and_buffers = itertools.chain(mod.parameters(), mod.buffers())
return next(parameters_and_buffers).dtype

opt_mod = torch._dynamo.optimize("eager")(get_parameter_dtype)
out_dtype = opt_mod(mod)
self.assertEqual(out_dtype, torch.float32)

def test_recursion(self):
mod = MockModule()
Expand Down
2 changes: 2 additions & 0 deletions torch/_dynamo/variables/nn_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,8 @@ def gen_source(source, name):
return wrap_values(module.named_modules())
elif name == "parameters":
return wrap_values(module.named_parameters(**get_kwargs("recurse")))
elif name == "buffers":
return wrap_values(module.named_buffers(**get_kwargs("recurse")))
elif name == "keys":
assert not (args or kwargs)
result = []
Expand Down