Allow more inserts before reIndexTopology #102312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102312
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 91ce1e3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zdevito
added a commit
that referenced
this pull request
May 25, 2023
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py ghstack-source-id: 80b872aa1bf2410ba6418d38aa66ac9906a16496 Pull Request resolved: #102312
|
@zdevito has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
eellison
approved these changes
May 25, 2023
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py Differential Revision: [D46206617](https://our.internmc.facebook.com/intern/diff/D46206617) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
May 31, 2023
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py ghstack-source-id: 73164b5b99b888dabcc4344ab10feea18ccb3986 Pull Request resolved: #102312
|
@zdevito has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot land |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
shaoyf42
pushed a commit
to shaoyf42/pytorch
that referenced
this pull request
Jun 1, 2023
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py Differential Revision: [D46206617](https://our.internmc.facebook.com/intern/diff/D46206617) Pull Request resolved: pytorch#102312 Approved by: https://github.com/eellison
alimoezzi
pushed a commit
to alimoezzi/pytorch
that referenced
this pull request
Jun 3, 2023
Summary: Currently if you are inserting into JIT IR at the same point in the middle of the graph, it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can lead to slow load times. This changes it so that it keeps track of how many insertions happen at single point (like when a function is being inlined) to predict how many future insertions will happen there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions. In practice this will allow around 2M inserts at a single point before it reindexes. Test Plan: test_jit.py Differential Revision: [D46206617](https://our.internmc.facebook.com/intern/diff/D46206617) Pull Request resolved: pytorch#102312 Approved by: https://github.com/eellison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Currently if you are inserting into JIT IR at the same point in the middle of the graph,
it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can
lead to slow load times. This changes it so that it keeps track of how many insertions happen
at single point (like when a function is being inlined) to predict how many future insertions will happen
there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions.
In practice this will allow around 2M inserts at a single point before it reindexes.
Test Plan: test_jit.py
Differential Revision: D46206617