Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more inserts before reIndexTopology #102312

Closed
wants to merge 2 commits into from

Commits on May 25, 2023

  1. Allow more inserts before reIndexTopology

    Summary:
    Currently if you are inserting into JIT IR at the same point in the middle of the graph,
    it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can
    lead to slow load times. This changes it so that it keeps track of how many insertions happen
    at single point (like when a function is being inlined) to predict how many future insertions will happen
    there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions.
    In practice this will allow around 2M inserts at a single point before it reindexes.
    
    Test Plan: test_jit.py
    
    [ghstack-poisoned]
    zdevito committed May 25, 2023
    Configuration menu
    Copy the full SHA
    dffa7a2 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Update on "Allow more inserts before reIndexTopology"

    Summary:
    Currently if you are inserting into JIT IR at the same point in the middle of the graph,
    it only allows for 40 inserts before it has to reindex. Reindexing is N**2 behavior, which can
    lead to slow load times. This changes it so that it keeps track of how many insertions happen
    at single point (like when a function is being inlined) to predict how many future insertions will happen
    there. It then adjusts how it assigns topology to make sure there is enough room for those predicted insertions.
    In practice this will allow around 2M inserts at a single point before it reindexes.
    
    Test Plan: test_jit.py
    
    Differential Revision: [D46206617](https://our.internmc.facebook.com/intern/diff/D46206617)
    
    [ghstack-poisoned]
    zdevito committed May 31, 2023
    Configuration menu
    Copy the full SHA
    91ce1e3 View commit details
    Browse the repository at this point in the history