Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dir(torch) for python 3.7 #10271

Closed
wants to merge 2 commits into from
Closed

Fix dir(torch) for python 3.7 #10271

wants to merge 2 commits into from

Conversation

li-roy
Copy link
Contributor

@li-roy li-roy commented Aug 6, 2018

fixes #10160.

Copy link
Member

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple test that calls dir(torch) in test_torch.py would be good

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Aug 10, 2018
Summary:
fixes pytorch#10160.
Pull Request resolved: pytorch#10271

Differential Revision: D9188031

Pulled By: li-roy

fbshipit-source-id: a3620553a8ba2b7391acdf78dbe58afcdb6c5f7f
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
fixes pytorch#10160.
Pull Request resolved: pytorch#10271

Differential Revision: D9188031

Pulled By: li-roy

fbshipit-source-id: a3620553a8ba2b7391acdf78dbe58afcdb6c5f7f
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dir(torch) fails in python3.7, pytorch0.4.1, breaks tab completion in IDEs
4 participants