[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml #103107

SherlockNoMad · 2023-06-06T20:41:39Z

Differential Revision: D46459100

pytorch-bot · 2023-06-06T20:41:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103107

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6064f49:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-06-06T20:42:25Z

This pull request was exported from Phabricator. Differential Revision: D46459100

angelayi

stamping based on previous land attempts

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: d0ae0ba9b4649cdbe4b929165483ce200af21083

linux-foundation-easycla · 2023-06-06T21:27:17Z

❌ The email address for the commit (aa23515) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot · 2023-06-06T21:27:22Z

This pull request was exported from Phabricator. Differential Revision: D46459100

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: eaee670d4a5607b60fba6d5ec1647f861ba7d09b

facebook-github-bot · 2023-06-06T21:36:40Z

This pull request was exported from Phabricator. Differential Revision: D46459100

linux-foundation-easycla · 2023-06-06T21:36:43Z

❌ The email address for the commit (fd4ed5b) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 bypass-github-export-checks Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: 4a6812c4f574823f48b94b47dab236427721b8bc

linux-foundation-easycla · 2023-06-07T20:38:06Z

❌ The email address for the commit (1b2cd79) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot · 2023-06-07T20:38:10Z

This pull request was exported from Phabricator. Differential Revision: D46459100

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 bypass-github-export-checks Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: 09c3fbe0dd04db24103245eaba1fd65a8a079afa

linux-foundation-easycla · 2023-06-08T08:43:27Z

❌ The email address for the commit (4406104) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

facebook-github-bot · 2023-06-08T08:43:34Z

This pull request was exported from Phabricator. Differential Revision: D46459100

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 bypass-github-export-checks Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: 09c3fbe0dd04db24103245eaba1fd65a8a079afa

linux-foundation-easycla · 2023-06-08T18:42:37Z

❌ The email address for the commit (6ad875d) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 bypass-github-export-checks Test Plan: sherlock :) Reviewed By: angelayi Differential Revision: D46459100 fbshipit-source-id: 09c3fbe0dd04db24103245eaba1fd65a8a079afa

facebook-github-bot · 2023-06-08T18:46:02Z

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 Reviewed By: angelayi Differential Revision: D46459100 Pulled By: SherlockNoMad fbshipit-source-id: 33c0de73253e343b4b5a315510879c2aa0508b32

facebook-github-bot · 2023-06-08T19:03:56Z

This pull request was exported from Phabricator. Differential Revision: D46459100

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 Reviewed By: angelayi Differential Revision: D46459100 Pulled By: SherlockNoMad fbshipit-source-id: f7c65880e77b1d78c426e0e77b871fbe6583976f

facebook-github-bot · 2023-06-09T17:47:55Z

This pull request was exported from Phabricator. Differential Revision: D46459100

* Serialized range constraints and inline constraints into symbols represented as strings * These symbols are then reconstructed in the deserialize_sym_int/bool functions by adding them to the shape env along with the ranges. * Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally takes in a shape env and map of symbols to names. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]

SherlockNoMad · 2023-06-12T16:39:59Z

@pytorchbot merge

pytorchmergebot · 2023-06-12T16:42:06Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

soulitzer

stamping for reland

* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally map of symbol names to range. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]

* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally map of symbol names to range. ReplaceSymSizeOpPass should not be needed after #103107 lands Pull Request resolved: #103273 Approved by: https://github.com/avikchaudhuri, https://github.com/zhxchen17

SherlockNoMad requested review from albanD and soulitzer as code owners June 6, 2023 20:41

pytorch-bot bot added the release notes: jit release notes category label Jun 6, 2023

facebook-github-bot added the fb-exported label Jun 6, 2023

angelayi approved these changes Jun 6, 2023

View reviewed changes

SherlockNoMad force-pushed the export-D46459100 branch from 96e7325 to aa23515 Compare June 6, 2023 21:27

SherlockNoMad force-pushed the export-D46459100 branch from aa23515 to fd4ed5b Compare June 6, 2023 21:36

SherlockNoMad force-pushed the export-D46459100 branch from fd4ed5b to 1b2cd79 Compare June 7, 2023 20:38

SherlockNoMad force-pushed the export-D46459100 branch from 1b2cd79 to 4406104 Compare June 8, 2023 08:43

SherlockNoMad force-pushed the export-D46459100 branch from 4406104 to 6ad875d Compare June 8, 2023 18:42

SherlockNoMad force-pushed the export-D46459100 branch from 6ad875d to ce98305 Compare June 8, 2023 18:45

SherlockNoMad force-pushed the export-D46459100 branch from ce98305 to 5f29ccd Compare June 8, 2023 19:03

angelayi mentioned this pull request Jun 8, 2023

[export] Serialize symbolic values #103273

Closed

[Reland] Add sym_size/stride/numel/storage_offset to native_function.…

6064f49

…yaml (pytorch#103107) Summary: Pull Request resolved: pytorch#103107 Reviewed By: angelayi Differential Revision: D46459100 Pulled By: SherlockNoMad fbshipit-source-id: f7c65880e77b1d78c426e0e77b871fbe6583976f

SherlockNoMad force-pushed the export-D46459100 branch from 5f29ccd to 6064f49 Compare June 9, 2023 17:47

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 12, 2023

pytorchmergebot added the merging label Jun 12, 2023

soulitzer approved these changes Jun 12, 2023

View reviewed changes

pytorchmergebot added Merged and removed merging labels Jun 12, 2023

pytorchmergebot closed this in d997969 Jun 12, 2023

ghost mentioned this pull request Jun 25, 2023

torch.ops.aten.sym_size output error with negative diment #98729

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml #103107

[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml #103107

SherlockNoMad commented Jun 6, 2023

pytorch-bot bot commented Jun 6, 2023 •

edited

facebook-github-bot commented Jun 6, 2023

angelayi left a comment

linux-foundation-easycla bot commented Jun 6, 2023

facebook-github-bot commented Jun 6, 2023

facebook-github-bot commented Jun 6, 2023

linux-foundation-easycla bot commented Jun 6, 2023

linux-foundation-easycla bot commented Jun 7, 2023

facebook-github-bot commented Jun 7, 2023

linux-foundation-easycla bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

linux-foundation-easycla bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

facebook-github-bot commented Jun 9, 2023

SherlockNoMad commented Jun 12, 2023

pytorchmergebot commented Jun 12, 2023

soulitzer left a comment

[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml #103107

[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml #103107

Conversation

SherlockNoMad commented Jun 6, 2023

pytorch-bot bot commented Jun 6, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103107

✅ No Failures

facebook-github-bot commented Jun 6, 2023

angelayi left a comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Jun 6, 2023

facebook-github-bot commented Jun 6, 2023

facebook-github-bot commented Jun 6, 2023

linux-foundation-easycla bot commented Jun 6, 2023

linux-foundation-easycla bot commented Jun 7, 2023

facebook-github-bot commented Jun 7, 2023

linux-foundation-easycla bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

linux-foundation-easycla bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

facebook-github-bot commented Jun 8, 2023

facebook-github-bot commented Jun 9, 2023

SherlockNoMad commented Jun 12, 2023

pytorchmergebot commented Jun 12, 2023

Merge started

soulitzer left a comment

Choose a reason for hiding this comment

pytorch-bot bot commented Jun 6, 2023 •

edited