[export] Serialize symbolic values #103273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103273
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed4ef55: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
angelayi
requested review from
avikchaudhuri,
zhxchen17 and
SherlockNoMad
and removed request for
avikchaudhuri
[ghstack-poisoned]
5 tasks
avikchaudhuri
requested changes
Jun 9, 2023
|
Requesting changes mainly because I'm unsure of the motivation behind adding extra params to graph module deserializer. |
avikchaudhuri
approved these changes
Jun 9, 2023
* Serialized range constraints and inline constraints into symbols represented as strings * These symbols are then reconstructed in the deserialize_sym_int/bool functions by adding them to the shape env along with the ranges. * Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally takes in a shape env and map of symbols to names. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]
angelayi
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 7c548e934c6e993cfb0dd9478058a28b106090cc Pull Request resolved: #103273
* Serialized range constraints and inline constraints into symbols represented as strings * These symbols are then reconstructed in the deserialize_sym_int/bool functions by adding them to the shape env along with the ranges. * Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally takes in a shape env and map of symbols to names. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]
angelayi
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 5beca86a3240cf7c7f61e0b740e166a639ee84d1 Pull Request resolved: #103273
zhxchen17
reviewed
Jun 12, 2023
* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally map of symbol names to range. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]
angelayi
added a commit
that referenced
this pull request
Jun 12, 2023
ghstack-source-id: a17228b8d3858d0230b86e4b4b4d536461248ae0 Pull Request resolved: #103273
* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node. * GraphModuleDeserializer.deserialize now also optionally map of symbol names to range. ReplaceSymSizeOpPass should not be needed after #103107 lands [ghstack-poisoned]
angelayi
added a commit
that referenced
this pull request
Jun 13, 2023
ghstack-source-id: 445954766a5e936669f17995a867ef8eb45f104d Pull Request resolved: #103273
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplaceSymSizeOpPass should not be needed after #103107 lands
Stack from ghstack (oldest at bottom):