Revert "[DDP] multiple forward support for static graph (#103487)" #103873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
added
ciflow/trunk
huydhn
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
pytorch-bot
bot
added
the
release notes: distributed (c10d)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103873
Note: Links to docs will display an error until the docs builds have been completed. ✅ 2 Unrelated FailuresAs of commit 2a59d33: BROKEN TRUNK - The following job failed but were present on the merge base 724a1ba:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Closed
rohan-varma
approved these changes
Jun 20, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rohan-varma
added a commit
that referenced
this pull request
Jun 21, 2023
…03487)" (#103873)" Differential Revision: [D46883396](https://our.internmc.facebook.com/intern/diff/D46883396/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 21, 2023
…03487)" (#103873)" Differential Revision: [D46883396](https://our.internmc.facebook.com/intern/diff/D46883396/) ghstack-source-id: 192716301 Pull Request resolved: #103938
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 22, 2023
…03487)" (#103873)" (#103938) Differential Revision: [D46883396](https://our.internmc.facebook.com/intern/diff/D46883396/) Pull Request resolved: #103938 Approved by: https://github.com/awgu, https://github.com/fegin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #103629 (comment), I preemptively create this revert PR to revert all commits in the stack. This seems like a safer option than using the bot as the commit has already been in trunk since last week.