-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make adding buffers more like adding parameters #104069
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104069
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 93e18f2 with merge base e43d656 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
release notes: quantization
release notes category
ciflow/inductor
module: dynamo
module: export
module: inductor
labels
Jun 28, 2023
ekamiti
requested review from
ezyang,
Chillee,
kulinseth,
BowenBao,
abock,
thiagocrepaldi,
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
jerryzh168,
albanD,
jbschlosser and
mikaylagawarecki
as code owners
July 1, 2023 01:55
ekamiti
requested review from
mruberry,
lezcano,
nikitaved,
IvanYashchuk,
ydwu4,
a team,
jataylo,
pruthvistony,
desertfire,
eellison,
shunting314,
bertmaher,
salilsdesai,
kimishpatel,
digantdesai,
jianyuh,
janeyx99,
soulitzer,
fmassa and
soumith
as code owners
May 9, 2024 23:07
pytorch-bot
bot
added
module: amp (automated mixed precision)
autocast
module: cpu
CPU specific problem (e.g., perf, algorithm)
module: distributed_checkpoint
module: mkldnn
Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration
oncall: distributed
Add this issue/PR to distributed oncall triage queue
labels
May 9, 2024
Bad rebase. Now we have too many people tagged on this one. Mind reopening a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/mps
Run MPS tests (subset of trunk)
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: amp (automated mixed precision)
autocast
module: cpu
CPU specific problem (e.g., perf, algorithm)
module: distributed_checkpoint
module: dynamo
module: inductor
module: mkldnn
Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration
oncall: distributed
Add this issue/PR to distributed oncall triage queue
open source
release notes: nn
release notes category
release notes: quantization
release notes category
Reverted
topic: improvements
topic category
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add similar semantics for creating a buffer object similar to creating a parameter. This is done by introducing a new
Buffer
class that can be used for type disambiguation. The underlying functionality of registering a buffer remains the same as theregister_buffer
method has not been changed. Thepersistent
parameter in theBuffer
type is to indicate whether a buffer object should be persistent or not. Other non-test changes have to do with getting the newBuffer
type recognized by inductor and dynamo. Remaining changes are test changes to make sure that theBuffer
type can be used as a drop in replacement forregister_buffer
as it just leads toregister_buffer
being called. The addition of this new functionality still allows for normal tensors to be used as buffers so these changes are intended to be backwards compatible.Fixes #35735
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @gujinghui @PenghuiCheng @jianyuh @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal @mcarilli @ptrblck @leslie-fang-intel @voznesenskym @EikanWang @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @LucasLLC @ngimel @aakhundov @anijain2305