[PyTorch] Add Vulkan support for at::softmax 1,2,3 dimension tensors #105012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
ciflow/periodic
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105012
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7939905: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D46985319 |
liuk22
added a commit
to liuk22/pytorch
that referenced
this pull request
Jul 11, 2023
…ytorch#105012) Summary: Pull Request resolved: pytorch#105012 This rounds out the support for the [softmax function](https://pytorch.org/docs/stable/generated/torch.nn.Softmax.html) on the Vulkan GPU backend. The test inputs of the 1,2,3 dimension cases are simply the truncated existing 4 dimension inputs. The existing shader algorithms are reused. Test Plan: 1. `buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1` on Apple M1 MacBook 2. Confirm all tests pass with no regression, and the added tests `*softmax*` pass under `-- --gtest_filter="*softmax*"` 2a. All tests P782531732 2b. `softmax` tests P782529114 ``` ~/fbsource » buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*softmax*" Buck UI: https://www.internalfb.com/buck2/692eb82d-c2ee-49bb-833f-3c11d6e2fea9 Jobs completed: 4. Time elapsed: 0.1s. Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *softmax* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.softmax [ OK ] VulkanAPITest.softmax (42 ms) [ DISABLED ] VulkanAPITest.DISABLED_log_softmax [----------] 1 test from VulkanAPITest (42 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (42 ms total) [ PASSED ] 1 test. YOU HAVE 1 DISABLED TEST ``` Reviewed By: SS-JIA Differential Revision: D46985319 fbshipit-source-id: 5a7cccd5da6c4c105afacd57305dd775eb437937
|
This pull request was exported from Phabricator. Differential Revision: D46985319 |
liuk22
added a commit
to liuk22/pytorch
that referenced
this pull request
Jul 11, 2023
…ytorch#105012) Summary: Pull Request resolved: pytorch#105012 This rounds out the support for the [softmax function](https://pytorch.org/docs/stable/generated/torch.nn.Softmax.html) on the Vulkan GPU backend. The test inputs of the 1,2,3 dimension cases are simply the truncated existing 4 dimension inputs. The existing shader algorithms are reused. Test Plan: 1. `buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1` on Apple M1 MacBook 2. Confirm all tests pass with no regression, and the added tests `*softmax*` pass under `-- --gtest_filter="*softmax*"` 2a. All tests P782531732 2b. `softmax` tests P782529114 ``` ~/fbsource » buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*softmax*" Buck UI: https://www.internalfb.com/buck2/692eb82d-c2ee-49bb-833f-3c11d6e2fea9 Jobs completed: 4. Time elapsed: 0.1s. Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *softmax* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.softmax [ OK ] VulkanAPITest.softmax (42 ms) [ DISABLED ] VulkanAPITest.DISABLED_log_softmax [----------] 1 test from VulkanAPITest (42 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (42 ms total) [ PASSED ] 1 test. YOU HAVE 1 DISABLED TEST ``` Reviewed By: SS-JIA Differential Revision: D46985319 fbshipit-source-id: 8e30a691232e07262e85c043dac78c7ab358527e
|
This pull request was exported from Phabricator. Differential Revision: D46985319 |
SS-JIA
approved these changes
Jul 12, 2023
…ytorch#105012) Summary: bypass-github-export-checks Pull Request resolved: pytorch#105012 This rounds out the support for the [softmax function](https://pytorch.org/docs/stable/generated/torch.nn.Softmax.html) on the Vulkan GPU backend. The test inputs of the 1,2,3 dimension cases are simply the truncated existing 4 dimension inputs. The existing shader algorithms are reused. Test Plan: 1. `buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1` on Apple M1 MacBook 2. Confirm all tests pass with no regression, and the added tests `*softmax*` pass under `-- --gtest_filter="*softmax*"` 2a. All tests P782531732 2b. `softmax` tests P782529114 ``` ~/fbsource » buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*softmax*" Buck UI: https://www.internalfb.com/buck2/692eb82d-c2ee-49bb-833f-3c11d6e2fea9 Jobs completed: 4. Time elapsed: 0.1s. Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *softmax* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.softmax [ OK ] VulkanAPITest.softmax (42 ms) [ DISABLED ] VulkanAPITest.DISABLED_log_softmax [----------] 1 test from VulkanAPITest (42 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (42 ms total) [ PASSED ] 1 test. YOU HAVE 1 DISABLED TEST ``` Reviewed By: SS-JIA Differential Revision: D46985319 fbshipit-source-id: 73fc0d4223bdf815b37ffb7ec80faf92b696cb38
|
This pull request was exported from Phabricator. Differential Revision: D46985319 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…n tensors (#105082) Fix lint. Follow up on: #105012 Pull Request resolved: #105082 Approved by: https://github.com/huydhn, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This rounds out the support for the softmax function on the Vulkan GPU backend. The test inputs of the 1,2,3 dimension cases are simply the truncated existing 4 dimension inputs. The existing shader algorithms are reused.
Test Plan:
buck2 run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1on Apple M1 MacBook*softmax*pass under-- --gtest_filter="*softmax*"2a. All tests P782531732
2b.
softmaxtests P782529114Reviewed By: SS-JIA
Differential Revision: D46985319