Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching NNC as default for TorchScript support #105185

Closed

Conversation

jjsjann123
Copy link
Collaborator

Disable nvfuser by default in TorchScript
Add deprecation warning for nvfuser usage via TorchScript and PrimTorch

Add deprecation warning for nvfuser usage via TorchScript and PrimTorch
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105185

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d12d22:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jul 13, 2023
@jjsjann123 jjsjann123 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 13, 2023
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 14, 2023
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though not sure if NNC would be default in this case)

Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks like the right way to make NNC the default

@davidberard98
Copy link
Contributor

although the failing test looks legitimate, may need to skip it?

@jjsjann123
Copy link
Collaborator Author

I'll try to take a look at the failing tests, but I also noticed some message from bot on that test: #103440

@jjsjann123
Copy link
Collaborator Author

Looks like the error is just coming from warning message I added 😆 skipped that part.

@jjsjann123
Copy link
Collaborator Author

failure coming from inductor and ROCM I'm not sure if they are relevant or not.:

2023-07-17T19:13:40.5706312Z Running inductor/test_cuda_repro 1/1 ... [2023-07-17 19:13:39.883309]
2023-07-17T19:13:40.5706447Z test_unary_ufuncs 1/1 failed! Received signal: SIGSEGV
2023-07-17T19:13:40.5707152Z Executing ['/opt/conda/envs/py_3.8/bin/python', '-bb', 'inductor/test_cuda_repro.py', '--shard-id=0', '--num-shards=1', '-v', '-vv', '-rfEX', '-p', 'no:xdist', '--use-pytest', '--sc=inductor/test_cuda_repro_0', '-x', '--reruns=2', '--import-slow-tests', '--import-disabled-tests'] ... [2023-07-17 19:13:39.883653]
2023-07-17T19:13:40.5707267Z Traceback (most recent call last):
2023-07-17T19:13:40.5707447Z   File "test/run_test.py", line 1683, in <module>
2023-07-17T19:13:40.5707565Z     main()
2023-07-17T19:13:40.5707692Z   File "test/run_test.py", line 1656, in main
2023-07-17T19:13:40.5707799Z     failure_messages += run_tests(
2023-07-17T19:13:40.5707927Z   File "test/run_test.py", line 1561, in run_tests
2023-07-17T19:13:40.5708017Z     raise RuntimeError(
2023-07-17T19:13:40.5708184Z RuntimeError: test_unary_ufuncs 1/1 failed! Received signal: SIGSEGV

@jjsjann123
Copy link
Collaborator Author

Looks like CI is clean now.

But there's an EasyCLA that I need to sign? is this something new or should I have pushed the branch to pytorch/pytorch and start the PR directly there?

cc'ing @davidberard98

@davidberard98
Copy link
Contributor

/easycla

@davidberard98
Copy link
Contributor

looks like that might have fixed it

@jjsjann123
Copy link
Collaborator Author

looks like that might have fixed it

Awesome~~ I guess this PR is good to go then.

@jjsjann123
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jjsjann123 jjsjann123 deleted the deprecation_warning_nvfuser branch July 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants