New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switching NNC as default for TorchScript support #105185
Conversation
Add deprecation warning for nvfuser usage via TorchScript and PrimTorch
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105185
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9d12d22: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though not sure if NNC would be default in this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks like the right way to make NNC the default
although the failing test looks legitimate, may need to skip it? |
I'll try to take a look at the failing tests, but I also noticed some message from bot on that test: #103440 |
Looks like the error is just coming from warning message I added 😆 skipped that part. |
failure coming from inductor and ROCM I'm not sure if they are relevant or not.:
|
Looks like CI is clean now. But there's an EasyCLA that I need to sign? is this something new or should I have pushed the branch to pytorch/pytorch and start the PR directly there? cc'ing @davidberard98 |
/easycla |
looks like that might have fixed it |
Awesome~~ I guess this PR is good to go then. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Disable nvfuser by default in TorchScript
Add deprecation warning for nvfuser usage via TorchScript and PrimTorch