Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching NNC as default for TorchScript support #105185

Closed
wants to merge 3 commits into from
Closed

switching NNC as default for TorchScript support #105185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b3a9e
Disable nvfuser by default in TorchScript
jjsjann123 Jul 13, 2023
b21c00f
skip warning check as part of phasing out
jjsjann123 Jul 17, 2023
9d12d22
Merge remote-tracking branch 'upstream/viable/strict' into deprecatio…
jjsjann123 Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions third_party/nvfuser/python_tests/test_dynamo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,7 @@ def func(a):
# nvfuser would promote output to fp32 in math, FusionDefinition should cast output dtype back
return torch.where(tmp > 0, tmp, 0.0)

# No warnings and no errors
with warnings.catch_warnings(record=True) as w:
nvfuser_result = func(input1)
self.assertEqual(len(w), 0)
nvfuser_result = func(input1)
eager_result = func.__wrapped__(input1)
self.assertEqual(eager_result, nvfuser_result)

Expand Down
1 change: 1 addition & 0 deletions torch/_prims/nvfuser_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ def nvfuser_execute(gm: GraphModule, *args, executor_parameters=None):
),
)
)
warn("nvfuser integration in primTorch is deprecated")
result = tree_unflatten(
fusion.execute(concrete_fusion_inputs), # type: ignore[has-type]
unflatten_spec, # type: ignore[has-type]
Expand Down
6 changes: 2 additions & 4 deletions torch/csrc/jit/codegen/cuda/interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,8 @@ class NVFuserEnabler {
return *getCachedFuserEnabledEnvVar();
}
// 3. default value
#if defined(USE_ROCM) || defined(FBCODE_CAFFE2)
// default off since TorchScript integration isn't maintained any longer
return false;
#else
return nvfuserCanBeEnabled();
#endif
}

public:
Expand Down Expand Up @@ -235,6 +232,7 @@ void fuseGraph(std::shared_ptr<Graph>& graph) {
return;
}

TORCH_WARN_ONCE("nvfuser integration in TorchScript is deprecated.");
TORCH_CHECK(
getFuserInterface()->fn_fuse_graph != nullptr,
"Running the CUDA fuser requires a CUDA build.");
Expand Down