Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSDP] Add record_function for explicit prefetching #105985

Closed
wants to merge 2 commits into from

Conversation

awgu
Copy link
Contributor

@awgu awgu commented Jul 25, 2023

Stack from ghstack (oldest at bottom):

Example:
Screenshot 2023-07-25 at 7 41 43 PM

This can be particularly help when with_stack=False, in which case it is harder to tell the prefetch.

Differential Revision: D47816318

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105985

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ 1 Unrelated Failure

As of commit 6fd6f82:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Jul 25, 2023
awgu added a commit that referenced this pull request Jul 25, 2023
ghstack-source-id: 8641fbd12ed0d87e71d1aef058646f2a59a94034
Pull Request resolved: #105985
@awgu
Copy link
Contributor Author

awgu commented Jul 25, 2023

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/awgu/430/orig returned non-zero exit code 1

Rebasing (1/2)
Auto-merging torch/distributed/fsdp/_exec_order_utils.py
CONFLICT (content): Merge conflict in torch/distributed/fsdp/_exec_order_utils.py
Auto-merging torch/distributed/fsdp/flat_param.py
CONFLICT (content): Merge conflict in torch/distributed/fsdp/flat_param.py
error: could not apply 55bd5ac83a7... Revert "Simplify handle indexing (#105006)"
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 55bd5ac83a7... Revert "Simplify handle indexing (#105006)"

Raised by https://github.com/pytorch/pytorch/actions/runs/5662928478

@awgu awgu added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 25, 2023
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

awgu added a commit that referenced this pull request Jul 26, 2023
ghstack-source-id: 955d0987842dd6c2083aa21ff18edf4209c39136
Pull Request resolved: #105985
@awgu awgu added the topic: improvements topic category label Jul 26, 2023
@awgu
Copy link
Contributor Author

awgu commented Jul 26, 2023

@awgu
Copy link
Contributor Author

awgu commented Jul 26, 2023

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@awgu
Copy link
Contributor Author

awgu commented Jul 26, 2023

@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/awgu/430/head branch July 29, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants