[FSDP][Easy] Rename to _comm_hook, _comm_hook_state
#106033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106033
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bd75ac1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 26, 2023
awgu
added
topic: not user facing
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
This is just out of preference to make the naming convention consistent with `register_comm_hook()`. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 26, 2023
ghstack-source-id: 595066cd9753b231c7e8c84af69f9727876f2150 Pull Request resolved: pytorch#106033
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 26, 2023
ghstack-source-id: 595066cd9753b231c7e8c84af69f9727876f2150 Pull Request resolved: pytorch#106033
This was referenced Jul 27, 2023
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 27, 2023
ghstack-source-id: d524bd5252b3bafa27bac8d2f18c0a6e8a3674cb Pull Request resolved: pytorch#106033
|
@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_post_backward_hookinto smaller funcs #106068div_for HSDP #106034_comm_hook,_comm_hook_state#106033record_functionfor explicit prefetching #105985This is just out of preference to make the naming convention consistent with
register_comm_hook().Differential Revision: D47852462