Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expect_true to make split with unbacked sizes work. #106788
Use expect_true to make split with unbacked sizes work. #106788
Changes from 6 commits
1dfa588
2c7bd27
2c5497d
1804469
bed9199
eb80f6b
41ce97c
0526cb2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start != cur_size test cannot be sym'ified since one branch is not an error condition. What I did here was inlined
maybe_wrap_dim
here, which conventionally tests-cur_size <= start < cur_size
; so you can make it work without extra branching by just changing this condition to-cur_size <= start <= cur_size
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can split out the inlining into its own PR if people would prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turns on expect_true for all our decomps/meta functions, pretty nice. (I couldn't do the same trick in C++; TORCH_CHECK is a very delicate macro and it was hard to insert expect_true without breaking some sites, and there's also the problem that operator< and friends actually return bool not SymBool).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nb. You can do a horrible, horrible thing, and locally overwrite the meaning of
<
insideTORCH_CHECK
via a macro so that you automagically go from usingoperator<
tolt
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this line is fantastic. Gotta love having just one entrypoint for a given thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two changes don't actually change semantics, but they're pretty important: frequently, we will know that end_val is <= sizes[dim], but we don't know if it == sizes[dim] or not. By branching only if it is truly out of bounds, we can statically determine which branch we go down. This is enough for split.