Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Use github environment for update-commit-hash workflow #107060

Closed
wants to merge 8 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Aug 11, 2023

Similar to: #101718

https://github.com/pytorch/pytorch/actions/runs/5856611801/job/15876722301

Please note since we can't specify environment for a composite workflow. It was needed to move update-commit-hash as action rather then workflow.

Still todo: Move docs and binary builds

@atalman atalman requested a review from a team as a code owner August 11, 2023 20:59
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 11, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107060

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit e23a0f0:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Use github environment for update-commit-hash Use github environment for update-commit-hash workflow Aug 11, 2023
@atalman atalman changed the title Use github environment for update-commit-hash workflow [Security] Use github environment for update-commit-hash workflow Aug 11, 2023
@atalman
Copy link
Contributor Author

atalman commented Aug 11, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have read it more carefully: I don't think one can specify the environment for a composite workflow, only for the top level one

@atalman
Copy link
Contributor Author

atalman commented Aug 11, 2023

Sorry, I should have read it more carefully: I don't think one can specify the environment for a composite workflow, only for the top level one

No Issues I will rewrite _update-commit-hash.yml as reusable action this way it should work with top level workflow similar to this example:

jobs:
  publish:
    environment: CI    # <--- /!\ Here is the link to the environment
    needs: build
    runs-on: ubuntu-latest
    if: startsWith(github.ref, 'refs/tags/v')
    steps:
    - uses: actions/checkout@v2
    # Some more steps here ...
    - name: Publish to Test PyPI
      env:
        TWINE_USERNAME: "__token__"
        TWINE_PASSWORD: ${{ secrets.TEST_PYPI_API_TOKEN }}
        TWINE_REPOSITORY_URL: "https://test.pypi.org/legacy/"
      run: |
       .....

@atalman
Copy link
Contributor Author

atalman commented Aug 14, 2023

@pytorchbot merge -f "rocm failures are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants