Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Use github environment for update-commit-hash workflow #107060

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/_update-commit-hash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,14 @@ on:
description: Path to folder with commit pin
required: false
default: .github/ci_commit_pins
secrets:
UPDATEBOT_TOKEN:
required: true
description: Permissions for opening PR
PYTORCHBOT_TOKEN:
required: true
description: Permissions for approving PR

env:
NEW_BRANCH_NAME: update-${{ inputs.repo-name }}-commit-hash/${{ github.run_id }}-${{ github.run_number }}-${{ github.run_attempt }}

jobs:
update-commit-hash:
runs-on: ubuntu-latest
environment: update-commit-hash
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,3 @@ jobs:
with:
repo-name: vision
branch: main
secrets:
UPDATEBOT_TOKEN: ${{ secrets.UPDATEBOT_TOKEN }}
PYTORCHBOT_TOKEN: ${{ secrets.GH_PYTORCHBOT_TOKEN }}
6 changes: 0 additions & 6 deletions .github/workflows/weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ jobs:
with:
repo-name: xla
branch: master
secrets:
UPDATEBOT_TOKEN: ${{ secrets.UPDATEBOT_TOKEN }}
PYTORCHBOT_TOKEN: ${{ secrets.GH_PYTORCHBOT_TOKEN }}

update-triton-commit-hash:
uses: ./.github/workflows/_update-commit-hash.yml
Expand All @@ -25,6 +22,3 @@ jobs:
repo-name: triton
branch: main
pin-folder: .ci/docker/ci_commit_pins
secrets:
UPDATEBOT_TOKEN: ${{ secrets.UPDATEBOT_TOKEN }}
PYTORCHBOT_TOKEN: ${{ secrets.GH_PYTORCHBOT_TOKEN }}