Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Set 'Generic[Diagnostic]' as base class for 'DiagnosticContext' #107165

Closed
wants to merge 4 commits into from
Closed

[ONNX] Set 'Generic[Diagnostic]' as base class for 'DiagnosticContext' #107165

wants to merge 4 commits into from
+56 −19

Commits on Aug 14, 2023

  1. [ONNX] Set 'Generic[Diagnostic]' as base class for 'DiagnosticContext' 

    Allows type checking for 'Diagnostic' argument when calling 'context.log'.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b378f32 View commit details
    Browse the repository at this point in the history

  2. Update on "[ONNX] Set 'Generic[Diagnostic]' as base class for 'Diagno… 

    …sticContext'"

Allows type checking for 'Diagnostic' argument when calling 'context.log'.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c476c8d View commit details
    Browse the repository at this point in the history

  3. Update on "[ONNX] Set 'Generic[Diagnostic]' as base class for 'Diagno… 

    …sticContext'"


Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3723dab View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Update on "[ONNX] Set 'Generic[Diagnostic]' as base class for 'Diagno… 

    …sticContext'"


Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8045fb0 View commit details
    Browse the repository at this point in the history