[ONNX] Set 'Generic[Diagnostic]' as base class for 'DiagnosticContext' #107165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows type checking for 'Diagnostic' argument when calling 'context.log'. [ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: onnx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107165
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 8045fb0 with merge base d8ad748 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
BowenBao
added a commit
that referenced
this pull request
Aug 14, 2023
Allows type checking for 'Diagnostic' argument when calling 'context.log'. ghstack-source-id: a7803c2c5ee6ede41b5b84e43a9f3098dcc453a0 Pull Request resolved: #107165
…sticContext'" Allows type checking for 'Diagnostic' argument when calling 'context.log'. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 14, 2023
Allows type checking for 'Diagnostic' argument when calling 'context.log'. ghstack-source-id: 9dc9cb7a903dc58970286e4f60a5b29702c87a19 Pull Request resolved: #107165
…sticContext'" Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 14, 2023
Allows type checking for 'Diagnostic' argument when calling 'context.log'. ghstack-source-id: bd9c342d4a32924b1c3a1ddbdf893c87d5b8d9a4 Pull Request resolved: #107165
justinchuby
approved these changes
Aug 15, 2023
titaiwangms
approved these changes
Aug 15, 2023
…sticContext'" Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 15, 2023
Allows type checking for 'Diagnostic' argument when calling 'context.log'. ghstack-source-id: c662af361b56c7bdb299e226375445763fbc02b8 Pull Request resolved: #107165
justinchuby
approved these changes
Aug 15, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 15, 2023
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. Pull Request resolved: #107245 Approved by: https://github.com/titaiwangms ghstack dependencies: #106741, #107158, #107165
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
pytorch#107165) Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking. Pull Request resolved: pytorch#107165 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: pytorch#106741, pytorch#107158
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
…107245) To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. Pull Request resolved: pytorch#107245 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#106741, pytorch#107158, pytorch#107165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Allows overriding the
Diagnostictype for DiagnosticContext and enable type checking.