Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Relax not exist assertion for 'register_pytree_node' #107245

Closed
wants to merge 2 commits into from
Closed

[ONNX] Relax not exist assertion for 'register_pytree_node' #107245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78f861a
[ONNX] Relax not exist assertion for 'register_pytree_node'
BowenBao Aug 15, 2023
0a4abd2
Update on "[ONNX] Relax not exist assertion for 'register_pytree_node'"
BowenBao Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions torch/onnx/_internal/fx/dynamo_graph_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ def register_pytree_node(
Raises:
AssertionError: If the custom python type is already registered.
"""
assert (
class_type not in pytree.SUPPORTED_NODES
and class_type not in self._extensions
), "PyTree node already registered"
if class_type in pytree.SUPPORTED_NODES or class_type in self._extensions:
# PyTree node already registered.
# E.g., `huggingface/transformer` registers `ModelOutput` as PyTree node after
# https://github.com/huggingface/transformers/pull/25358.
return
self._extensions[class_type] = (flatten_func, unflatten_func)

def _register_huggingface_model_output_extension(self):
Expand Down