[ONNX] Relax not exist assertion for 'register_pytree_node' #107245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 15, 2023
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. ghstack-source-id: 70e50b0e6cda42888a117188a9e5c18f3f40acd7 Pull Request resolved: #107245
titaiwangms
approved these changes
Aug 15, 2023
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 15, 2023
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. ghstack-source-id: 518a747bdb894e65a82c898161f512a9c8768dcc Pull Request resolved: #107245
BowenBao
added
release notes: onnx
|
@pytorchbot merge |
1 similar comment
|
@pytorchbot merge |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107245
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a4abd2 with merge base d8ad748 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
…107245) To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. Pull Request resolved: pytorch#107245 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#106741, pytorch#107158, pytorch#107165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To not conflict with potential existing workaround or solution outside of exporter.
Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over
ModelOutputclass._PyTreeExtensionContextis kept to support prior versions of transformers.