Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Re-purpose 'name' field of GraphProto #107408

Closed
wants to merge 5 commits into from
Closed

[ONNX] Re-purpose 'name' field of GraphProto #107408

wants to merge 5 commits into from

Commits on Aug 17, 2023

  1. [ONNX] Re-purpose 'name' field of GraphProto 

    [ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c15553b View commit details
    Browse the repository at this point in the history

  2. revert some value changes in expect file on "[ONNX] Re-purpose 'name'… 

    … field of GraphProto"

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0aca29e View commit details
    Browse the repository at this point in the history

  3. fix on "[ONNX] Re-purpose 'name' field of GraphProto" 

    [ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3b16944 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Update on "[ONNX] Re-purpose 'name' field of GraphProto" 

    [ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    db3f4c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. adjust package name; remove xfail for unexpected pass on "[ONNX] Re-p… 

    …urpose 'name' field of GraphProto"


Previously, the top level GraphProto is hardcoded with name "torch_jit", and the subgraphs "torch_jit_{count}". It does not offer any insight to the graph, but rather encodes the graph producer as jit (torchscript). This is no longer true now that the graph can also be produced from dynamo.

As a naive first step, this PR re-purposes the name, to "main_graph", and "sub_graph_{count}" respectively. More delicate processing can be done to name the subgraphs with respect to their parent node or module. This can be done as follow ups.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    51e2e68 View commit details
    Browse the repository at this point in the history