[ONNX] Re-purpose 'name' field of GraphProto #107408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107408
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 51e2e68 with merge base 3f3479e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
BowenBao
added a commit
that referenced
this pull request
Aug 17, 2023
ghstack-source-id: 0a6e24f20488f57c42be426ea93951f7181abdd0 Pull Request resolved: #107408
… field of GraphProto" [ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
BowenBao
requested review from
abock,
thiagocrepaldi and
wschin
as code owners
This was referenced Aug 22, 2023
justinchuby
approved these changes
Aug 22, 2023
titaiwangms
approved these changes
Aug 22, 2023
…urpose 'name' field of GraphProto"
Previously, the top level GraphProto is hardcoded with name "torch_jit", and the subgraphs "torch_jit_{count}". It does not offer any insight to the graph, but rather encodes the graph producer as jit (torchscript). This is no longer true now that the graph can also be produced from dynamo.
As a naive first step, this PR re-purposes the name, to "main_graph", and "sub_graph_{count}" respectively. More delicate processing can be done to name the subgraphs with respect to their parent node or module. This can be done as follow ups.
[ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2023
…107409) Enclose source package of modules that are exported as onnx local function in exported onnx model. GPT2 model example: <img width="350" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/5e361bdd-ca24-45e7-a9ba-191c35acf3bb"> Pull Request resolved: #107409 Approved by: https://github.com/justinchuby ghstack dependencies: #107408
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2023
Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. Pull Request resolved: #107653 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: #107408, #107409
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2023
Summary: - Log fx graph name for 'fx-graph-to-onnx' diagnostic. - Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic. - Adjust unittest to run with diagnostics verbosity level logging.DEBUG. - Sarif logs will be saved for unittest when `TORCH_LOGS="onnx_diagnostics"` is set. <img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7"> Pull Request resolved: #107654 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: #107408, #107409, #107653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, the top level GraphProto is hardcoded with name "torch_jit", and the subgraphs "torch_jit_{count}". It does not offer any insight to the graph, but rather encodes the graph producer as jit (torchscript). This is no longer true now that the graph can also be produced from dynamo.
As a naive first step, this PR re-purposes the name, to "main_graph", and "sub_graph_{count}" respectively. More delicate processing can be done to name the subgraphs with respect to their parent node or module. This can be done as follow ups.