Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Clean up diagnostic rules #107653

Closed
wants to merge 5 commits into from
Closed

[ONNX] Clean up diagnostic rules #107653

wants to merge 5 commits into from

Commits on Aug 22, 2023

  1. [ONNX] Clean up diagnostic rules 

    Summary:

- Remove experimental rules that were never used.
- Fill in detailed rule descriptions.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2f6600f View commit details
    Browse the repository at this point in the history

  2. adjust package name; remove xfail for unexpected pass on "[ONNX] Clea… 

    …n up diagnostic rules"

Summary:

- Remove experimental rules that were never used.
- Fill in detailed rule descriptions.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d02b20a View commit details
    Browse the repository at this point in the history

  3. use commit from onnxscript main in CI on "[ONNX] Clean up diagnostic … 

    …rules"

Summary:

- Remove experimental rules that were never used.
- Fill in detailed rule descriptions.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3d5ef41 View commit details
    Browse the repository at this point in the history

  4. adjust xfail removal between commits; enable sarif log saving for uni… 

    …ttest when logs enabled on "[ONNX] Clean up diagnostic rules"

Summary:

- Remove experimental rules that were never used.
- Fill in detailed rule descriptions.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7f11957 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. remove more xfails on "[ONNX] Clean up diagnostic rules" 

    Summary:

- Remove experimental rules that were never used.
- Fill in detailed rule descriptions.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    dff54ae View commit details
    Browse the repository at this point in the history