[ONNX] Clean up diagnostic rules #107653
Closed
[ONNX] Clean up diagnostic rules #107653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107653
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dff54ae with merge base 3f3479e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
This was referenced Aug 22, 2023
BowenBao
commented
Aug 22, 2023
There was a problem hiding this comment.
This is codegen file, please ignore.
BowenBao
commented
Aug 22, 2023
There was a problem hiding this comment.
This is codegen file, please ignore.
BowenBao
requested review from
abock,
thiagocrepaldi and
wschin
as code owners
justinchuby
approved these changes
Aug 22, 2023
titaiwangms
approved these changes
Aug 22, 2023
…n up diagnostic rules" Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. [ghstack-poisoned]
…rules" Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. [ghstack-poisoned]
…ttest when logs enabled on "[ONNX] Clean up diagnostic rules" Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. [ghstack-poisoned]
Summary: - Remove experimental rules that were never used. - Fill in detailed rule descriptions. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2023
Summary: - Log fx graph name for 'fx-graph-to-onnx' diagnostic. - Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic. - Adjust unittest to run with diagnostics verbosity level logging.DEBUG. - Sarif logs will be saved for unittest when `TORCH_LOGS="onnx_diagnostics"` is set. <img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7"> Pull Request resolved: #107654 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: #107408, #107409, #107653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: