New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus builds of macOS apps on apple silicon. (#96966) #107816

Closed

vitalii-topoliuk wants to merge 1 commit into pytorch:main from vitalii-topoliuk:export-D44076509

Contributor

vitalii-topoliuk commented Aug 23, 2023

Summary:

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the user.focus_enabled=true config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

pytorch-bot bot commented Aug 23, 2023 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107816

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d0f69a9 with merge base 182a9cf ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla bot commented Aug 23, 2023 •

edited

The committers listed above are authorized under a signed CLA.

✅ login: vitalii-topoliuk (d0f69a9)

github-actions bot commented Aug 23, 2023

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Contributor

facebook-github-bot commented Aug 23, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 23, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

vitalii-topoliuk added a commit to vitalii-topoliuk/pytorch that referenced this pull request


          Fix focus builds of macOS apps on apple silicon. (pytorch#107816)

f9aca3e

Summary:
Pull Request resolved: pytorch#107816

Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: 4b8867b752e907b820ec02ef24022eb14395d100

vitalii-topoliuk force-pushed the export-D44076509 branch from b6f4fb1 to f9aca3e Compare

August 23, 2023 20:25

Contributor

facebook-github-bot commented Aug 24, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

1 similar comment

Contributor

facebook-github-bot commented Aug 24, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

vitalii-topoliuk force-pushed the export-D44076509 branch from f9aca3e to 8a44df1 Compare

August 24, 2023 18:25

vitalii-topoliuk added a commit to vitalii-topoliuk/pytorch that referenced this pull request


          Fix focus builds of macOS apps on apple silicon. (pytorch#107816)

8a44df1

Summary:
Pull Request resolved: pytorch#107816

Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: 80948c9032a84560201f321a5c809220fe5209bd

kit1980 approved these changes

View reviewed changes

Contributor Author

vitalii-topoliuk commented Aug 28, 2023

/easycla


          Fix focus builds of macOS apps on apple silicon. (pytorch#107816)

d0f69a9

Summary:
Pull Request resolved: pytorch#107816

Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: b80ee07094a31caaf29deb10e53527dfd3ca1e73

Contributor

facebook-github-bot commented Aug 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

vitalii-topoliuk force-pushed the export-D44076509 branch from 8a44df1 to d0f69a9 Compare

August 28, 2023 19:20

Contributor

facebook-github-bot commented Aug 29, 2023

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Aug 29, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

525b593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment