New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus builds of macOS apps on apple silicon. #96966

Closed

bwhiteley wants to merge 1 commit into pytorch:main from bwhiteley:export-D44076509

bwhiteley commented Mar 16, 2023

Summary: Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the user.focus_enabled=true config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

pytorch-bot bot commented Mar 16, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96966

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm jobs are failing with No space left on device

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla bot commented Mar 16, 2023 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: bwhiteley / name: Bart Whiteley (31545a05012fa1bfba3f9ef70d054a911bd8849b)

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Mar 16, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

Author

bwhiteley commented Mar 17, 2023

/easycla

Contributor

facebook-github-bot commented Mar 31, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley force-pushed the export-D44076509 branch from 31545a0 to eb8857f Compare

March 31, 2023 19:47

malfet approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Apr 5, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley force-pushed the export-D44076509 branch from eb8857f to daff1c8 Compare

April 5, 2023 04:11

Contributor

facebook-github-bot commented Apr 6, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley force-pushed the export-D44076509 branch from daff1c8 to 5f4ab60 Compare

April 6, 2023 19:57

Contributor

facebook-github-bot commented Apr 11, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley force-pushed the export-D44076509 branch from 5f4ab60 to 8a08389 Compare

April 11, 2023 16:10


          Fix focus builds of macOS apps on apple silicon. (pytorch#96966)

580fe55

Summary:
Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: 22da602160d7a7876067d06e44dcc55585988c8a

Contributor

facebook-github-bot commented Apr 24, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley force-pushed the export-D44076509 branch from 8a08389 to 580fe55 Compare

April 24, 2023 15:55

github-actions bot commented Jun 23, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the Stale label

github-actions bot closed this

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

1 similar comment

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

Contributor

facebook-github-bot commented Aug 23, 2023

This pull request was exported from Phabricator. Differential Revision: D44076509

bwhiteley pushed a commit to bwhiteley/pytorch that referenced this pull request


          Fix focus builds of macOS apps on apple silicon. (pytorch#96966)

a127b40

Summary:
Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: a6c22aba2bb224d07ff7b240fb6854e35ad585f8

vitalii-topoliuk added a commit to vitalii-topoliuk/pytorch that referenced this pull request


          Fix focus builds of macOS apps on apple silicon. (pytorch#107816)

d0f69a9

Summary:
Pull Request resolved: pytorch#107816

Pull Request resolved: pytorch#96966

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

fbshipit-source-id: b80ee07094a31caaf29deb10e53527dfd3ca1e73

pytorchmergebot pushed a commit that referenced this pull request


          Fix focus builds of macOS apps on apple silicon. (#96966) (#107816)

525b593

Summary:

Focus2 builds of some apps on apple silicon Macs are failing. We've determined that removing the `user.focus_enabled=true` config option allows the build to succeed.

Reviewed By: milend

Differential Revision: D44076509

Pull Request resolved: #107816
Approved by: https://github.com/kit1980

kit1980 mentioned this pull request

[caffe2] Clean up platform-specific fbobjc deps/flags #106193

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment