New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue described by #106769 #108340
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108340
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 73c6576 with merge base c8e72a4 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mikaylagawarecki, @albanD, Hi, sorry to bother you guys, please take a look at this, thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing -- could we please add some small tests to ensure that the error messages get raised properly
1. Remove some duplicate checks 2. Add some checks 3. support 1D 4. Add Test
d3ba49e
to
6e1bc9e
Compare
6e1bc9e
to
73c6576
Compare
Of course, have added some tests and found a tiny bug. |
@mikaylagawarecki , please have a look at this, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #106769
Align the behavior of the C++ interface with the Python interface
pytorch/aten/src/ATen/native/RNN.cpp
Lines 676 to 690 in 50fa588