[FSDP][optim_state_dict] Add device to _shard_utils.py to explicitly use the device from fsdp_state #109631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use the device from fsdp_state _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fduwjj,
kiukchung,
d4l3k and
wz337
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109631
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 73d4909 with merge base 71b4b32 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
fegin
added a commit
that referenced
this pull request
Sep 19, 2023
…use the device from fsdp_state _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/) ghstack-source-id: 201220846 Pull Request resolved: #109631
fduwjj
approved these changes
Sep 19, 2023
|
LGTM! |
wz337
approved these changes
Sep 19, 2023
…explicitly use the device from fsdp_state" _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Sep 19, 2023
…use the device from fsdp_state Pull Request resolved: #109631 _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. ghstack-source-id: 201245744 @exported-using-ghexport Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/)
…explicitly use the device from fsdp_state" _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Sep 19, 2023
…use the device from fsdp_state Pull Request resolved: #109631 _get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device. ghstack-source-id: 201254722 @exported-using-ghexport Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device.
Differential Revision: D49425743