Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSDP][optim_state_dict] Add device to _shard_utils.py to explicitly use the device from fsdp_state #109631

Closed
wants to merge 3 commits into from
Closed

[FSDP][optim_state_dict] Add device to _shard_utils.py to explicitly use the device from fsdp_state #109631

wants to merge 3 commits into from

Commits on Sep 19, 2023

  1. [FSDP][optim_state_dict] Add device to _shard_utils.py to explicitly … 

    …use the device from fsdp_state

_get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device.

Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/)

[ghstack-poisoned]
    @fegin
    fegin committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0558d87 View commit details
    Browse the repository at this point in the history

  2. Update on "[FSDP][optim_state_dict] Add device to _shard_utils.py to … 

    …explicitly use the device from fsdp_state"

_get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device.

Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/)

[ghstack-poisoned]
    @fegin
    fegin committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6913ed1 View commit details
    Browse the repository at this point in the history

  3. Update on "[FSDP][optim_state_dict] Add device to _shard_utils.py to … 

    …explicitly use the device from fsdp_state"

_get_pg_default_device does not always get the device we want. This PR let the user explicitly tell use the correct device.

Differential Revision: [D49425743](https://our.internmc.facebook.com/intern/diff/D49425743/)

[ghstack-poisoned]
    @fegin
    fegin committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    73d4909 View commit details
    Browse the repository at this point in the history