Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minor issues for bmm/mm decompositon #109836

Closed
wants to merge 1 commit into from
Closed

Fixed minor issues for bmm/mm decompositon #109836

wants to merge 1 commit into from

Conversation

chenyang78
Copy link
Contributor

@chenyang78 chenyang78 commented Sep 21, 2023 •
edited by pytorch-bot bot

Summary:

  • Fixed minor issues for bmm/mm decompositon
  • enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @kadeng @muchulee8 @aakhundov @ColinPeppler @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109836

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 0801683 with merge base 7f5fd92 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

@chenyang78 chenyang78 added the topic: not user facing topic category label Sep 21, 2023
jansel
jansel requested changes Sep 22, 2023
View reviewed changes
torch/_inductor/decomposition.py Outdated
@@ -29,6 +29,7 @@
inductor_decompositions = get_decompositions(
[
aten._adaptive_avg_pool2d_backward,
aten.addmm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is causing the test failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, quite a few accuracy issues. I remove this part from this PR. It may take more time to triage and fix those issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #110010 I just added a custom addmm decomp for this case. I'm not sure what changed since July that this is needed.

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 22, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
3221ce7 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 22, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
7111038 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 23, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
b39f66f 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@chenyang78 chenyang78 force-pushed the export-D49522332 branch 2 times, most recently from f50ed28 to b39f66f Compare September 23, 2023 00:13
chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 23, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
f50ed28 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 26, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
865c980 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 26, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
aa49473 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 27, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
51b1f61 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@chenyang78 chenyang78 force-pushed the export-D49522332 branch 2 times, most recently from 865c980 to 66e3f17 Compare September 27, 2023 06:43
chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 27, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
66e3f17 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 28, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
bde7066 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 28, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
950ea7a 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

@mikekgfb
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 14 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
0801683 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
chenyang78 added a commit to chenyang78/pytorch that referenced this pull request Sep 28, 2023
@chenyang78 @facebook-github-bot
Fixed minor issues for bmm/mm decompositon (pytorch#109836)
c0c14b0 
Summary:

* Fixed minor issues for bmm/mm decompositon
* enabled addmm for inductor

Test Plan: ci

Reviewed By: mikekgfb

Differential Revision: D49522332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49522332

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@mikekgfb mikekgfb mikekgfb approved these changes

@Chillee Chillee Awaiting requested review from Chillee

@bertmaher bertmaher Awaiting requested review from bertmaher

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chenyang78 @facebook-github-bot @mikekgfb @pytorchmergebot @jansel @bertmaher