[inductor] Decompose addmm if it's a dot product on cpu #110010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated code for dot product is often faster (on CPU) than dispatching to aten, since it avoids op dispatch overhead and allows fusion with surrounding ops, which in turn avoids allocations. Differential Revision: [D49595876](https://our.internmc.facebook.com/intern/diff/D49595876/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110010
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 921607c with merge base 92d86cd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bertmaher
added a commit
that referenced
this pull request
Sep 25, 2023
Generated code for dot product is often faster (on CPU) than dispatching to aten, since it avoids op dispatch overhead and allows fusion with surrounding ops, which in turn avoids allocations. Differential Revision: [D49595876](https://our.internmc.facebook.com/intern/diff/D49595876/) ghstack-source-id: 201785775 Pull Request resolved: #110010
jgong5
approved these changes
Sep 27, 2023
mikekgfb
approved these changes
Sep 27, 2023
Generated code for dot product is often faster (on CPU) than dispatching to aten, since it avoids op dispatch overhead and allows fusion with surrounding ops, which in turn avoids allocations. Differential Revision: [D49595876](https://our.internmc.facebook.com/intern/diff/D49595876/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Sep 27, 2023
Pull Request resolved: #110010 Generated code for dot product is often faster (on CPU) than dispatching to aten, since it avoids op dispatch overhead and allows fusion with surrounding ops, which in turn avoids allocations. ghstack-source-id: 202094380 @exported-using-ghexport Differential Revision: [D49595876](https://our.internmc.facebook.com/intern/diff/D49595876/)
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Generated code for dot product is often faster (on CPU) than
dispatching to aten, since it avoids op dispatch overhead and allows fusion
with surrounding ops, which in turn avoids allocations.
Differential Revision: D49595876
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler