[core IR] Add a core decomposition for floor_divide #110046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110046
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 75d4547 with merge base 52e1478 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Sep 25, 2023
ghstack-source-id: 24e3f183889d3a2d988bd05cff681d45d191485e Pull Request resolved: #110046
## Context Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table. [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 25, 2023
ghstack-source-id: 6accf4059304c69be09523b8ff0ee801da48475c Pull Request resolved: #110046
|
I don't quite remember what was the issue here really. I think that back then, our lowering for If this was indeed the reason (let's see if Peter remembers) then I guess we can move it to core, yep. |
peterbell10
approved these changes
Sep 26, 2023
## Context Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table. This replaces the decomposition of `floor_divide` that was used by Inductor. I noticed there was a note on that decomposition ``` # TorchInductor-only decomposition. It should not be taken to core. # See pytorch/torchdynamo#1120 ``` but couldn't discern the reason why this is the case. cc: lezcano cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 26, 2023
ghstack-source-id: 204fa68c34379511fedb36e74d24cbcff3fcca77 Pull Request resolved: #110046
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Sep 26, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. Pull Request resolved: #110043 Approved by: https://github.com/peterbell10, https://github.com/lezcano ghstack dependencies: #110046
ringohoffman
pushed a commit
to ringohoffman/pytorch
that referenced
this pull request
Sep 27, 2023
## Context Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table. This replaces the decomposition of `floor_divide` that was used by Inductor. I noticed there was a note on that decomposition ``` # TorchInductor-only decomposition. It should not be taken to core. # See pytorch/torchdynamo#1120 ``` but couldn't discern the reason why this is the case. cc: @lezcano Pull Request resolved: pytorch#110046 Approved by: https://github.com/peterbell10
ringohoffman
pushed a commit
to ringohoffman/pytorch
that referenced
this pull request
Sep 27, 2023
## Context Add the decomposition for `aten.glu` as a decomposition in the core ATen decomposition table. Don't use it in the Inductor decomposition table since Inductor has a lowering for it. Pull Request resolved: pytorch#110043 Approved by: https://github.com/peterbell10, https://github.com/lezcano ghstack dependencies: pytorch#110046
Git-tjb
pushed a commit
to Git-tjb/MyPytorch
that referenced
this pull request
Oct 6, 2023
ghstack-source-id: 37b9e14da1f577f3589e530d687af135c9dc9444 Pull Request resolved: pytorch/pytorch#110046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Introduce a core decomposition for
aten.floor_divideinto otheratenops, and add it to the core ATen decomposition table.This replaces the decomposition of
floor_dividethat was used by Inductor. I noticed there was a note on that decompositionbut couldn't discern the reason why this is the case. cc: @lezcano
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov