Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core IR] Add a core decomposition for floor_divide #110046

Closed
wants to merge 3 commits into from

Commits on Sep 25, 2023

  1. [core IR] Add a core decomposition for floor_divide

    [ghstack-poisoned]
    SS-JIA committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4908485 View commit details
    Browse the repository at this point in the history
  2. Update on "[core IR] Add a core decomposition for floor_divide"

    ## Context
    
    Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table.
    
    
    [ghstack-poisoned]
    SS-JIA committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1042df6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Update on "[core IR] Add a core decomposition for floor_divide"

    ## Context
    
    Introduce a core decomposition for `aten.floor_divide` into other `aten` ops, and add it to the core ATen decomposition table.
    
    This replaces the decomposition of `floor_divide` that was used by Inductor. I noticed there was a note on that decomposition
    
    ```
    # TorchInductor-only decomposition. It should not be taken to core.
    # See pytorch/torchdynamo#1120
    ```
    
    but couldn't discern the reason why this is the case. cc: lezcano 
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov
    
    [ghstack-poisoned]
    SS-JIA committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    75d4547 View commit details
    Browse the repository at this point in the history