Add 9.0a to cpp_extension supported compute archs #110587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110587
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 4e6b137 with merge base c36b31d ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Oct 5, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 3, 2024
…123243) When people build pytorch extensions with cmake, and the GPU supports 9.0a arch as introduced in #110587 , the cmake regex is not updated to recognize the change, leading to cmake breaks like #113948 and #119946 . This PR should fix them. Pull Request resolved: #123243 Approved by: https://github.com/malfet
sanketpurandare
pushed a commit
to sanketpurandare/pytorch
that referenced
this pull request
Apr 22, 2024
…ytorch#123243) When people build pytorch extensions with cmake, and the GPU supports 9.0a arch as introduced in pytorch#110587 , the cmake regex is not updated to recognize the change, leading to cmake breaks like pytorch#113948 and pytorch#119946 . This PR should fix them. Pull Request resolved: pytorch#123243 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an extended compute capability 9.0a for Hopper that was introduced in Cuda 12.0: https://docs.nvidia.com/cuda/archive/12.0.0/cuda-compiler-driver-nvcc/index.html#gpu-feature-list
E.g. Cutlass leverages it: https://github.com/NVIDIA/cutlass/blob/5f13dcad781284678edafa3b8d108120cfc6a6e4/python/cutlass/emit/pytorch.py#L684
This adds it to the list of permitted architectures to use in
cpp_extensiondirectly.