Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up composite implicit ops for aten::isfinite, isreal and log_sigmoid #110896

Closed

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Oct 9, 2023

Stack from ghstack (oldest at bottom):

Functions:

  • aten::isfinite
  • aten::log_sigmoide
  • aten::isreal

…:isreal, aten::log_sigmoid and

aten::real

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110896

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a61ecbf with merge base 733368a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guilhermeleobas added a commit that referenced this pull request Oct 9, 2023
…:isreal, aten::log_sigmoid and

aten::real

ghstack-source-id: cb8ee259a0433aeaea48a7dbe4c2bdda549ef048
Pull Request resolved: #110896
@guilhermeleobas guilhermeleobas changed the title Clean-up composite implicit ops for aten::imag, aten::isfinite, aten::isreal, aten::log_sigmoid and Clean-up composite implicit ops for aten::imag, isfinite, isreal, log_sigmoid and real Oct 9, 2023
…isreal, log_sigmoid and real"



Functions:
* aten::real
* aten::imag
* aten::isfinite
* aten::log_sigmoide
* aten::isreal

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Oct 10, 2023
…n::log_sigmoid

ghstack-source-id: ef4ce260ead8da2e187a38fa36021212b3570810
Pull Request resolved: #110896
@guilhermeleobas guilhermeleobas changed the title Clean-up composite implicit ops for aten::imag, isfinite, isreal, log_sigmoid and real Clean-up composite implicit ops for aten::isfinite, isreal and log_sigmoid Oct 10, 2023
@guilhermeleobas guilhermeleobas marked this pull request as ready for review October 10, 2023 17:02
@guilhermeleobas guilhermeleobas added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Oct 10, 2023
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @guilhermeleobas

@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/guilhermeleobas/9/head branch October 15, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants