Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flatten.using_ints, linalg_*, linear, log_softmax.int, logdet, special_* from xfail list #110985

Closed

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Oct 10, 2023

… special_* from xfail list

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110985

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 26634de with merge base 619ae87 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guilhermeleobas added a commit that referenced this pull request Oct 10, 2023
… special_* from xfail list

ghstack-source-id: b9a62a39de789dee7d92de3b808431a9c284b073
Pull Request resolved: #110985
…nt, logdet, special_* from xfail list"

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Oct 10, 2023
… special_* from xfail list

ghstack-source-id: 7463a8c730e05a472358af5f8aa02bfa215c5755
Pull Request resolved: #110985
@guilhermeleobas guilhermeleobas added the module: functorch Pertaining to torch.func or pytorch/functorch label Oct 11, 2023
@guilhermeleobas guilhermeleobas marked this pull request as ready for review October 11, 2023 13:17
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor questions on if we can delete more code

…nt, logdet, special_* from xfail list"

cc zou3519 Chillee samdow kshitij12345 janeyx99

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Oct 11, 2023
… special_* from xfail list

ghstack-source-id: f1d91ccb88822e198f204555a8e094fee968c409
Pull Request resolved: #110985
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@guilhermeleobas guilhermeleobas added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Oct 20, 2023
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 6fb1cbcba4fc41a19b71733ef3de62bebfece4f3 returned non-zero exit code 1

Auto-merging aten/src/ATen/functorch/BatchRulesBinaryOps.cpp
Auto-merging aten/src/ATen/functorch/BatchRulesDecompositions.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/functorch/BatchRulesDecompositions.cpp
Auto-merging aten/src/ATen/functorch/BatchRulesViews.cpp
Auto-merging test/functorch/test_vmap_registrations.py
CONFLICT (content): Merge conflict in test/functorch/test_vmap_registrations.py
error: could not apply 6fb1cbcba4f... remove flatten.using_ints, linalg_*, linear, log_softmax.int, logdet, special_* from xfail list
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

…nt, logdet, special_* from xfail list"

cc zou3519 Chillee samdow kshitij12345 janeyx99

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Oct 20, 2023
… special_* from xfail list

ghstack-source-id: d44c0a597bc9701b238eede6efb2d1faa15569e8
Pull Request resolved: #110985
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/guilhermeleobas/10/head branch October 24, 2023 14:23
andreigh pushed a commit to andreigh/pytorch that referenced this pull request Oct 26, 2023
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: functorch Pertaining to torch.func or pytorch/functorch open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants