S390x inductor support #111367
Closed
S390x inductor support #111367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111367
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2ab18d7 with merge base 619ae87 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
module: cpu
janeyx99
added
the
triaged
Use arch compile flags. They are needed for vectorization support on s390x. This change fixes multiple tests in test_cpu_repro.py
This change fixes remaining tests in test_cpu_repro.py
Make str return 'zvector' instead of 'vx' since it is used to generate macros like -DCPU_CAPABILITY=ZVECTOR. Rework vectorization detection for s390x. Also rework macros generation to allow more than 1 macro provided.
Provide list of directories instead of -I directives. Function _write_ninja_file_to_build_library is eventually called and it expects list of paths. If include directive is provided, it generates bogus output like: -I/home/user/pytorch/-I/home/user/pytorch/torch/include -I/home/user/pytorch/torch/include/torch/csrc/api/include ... when original input is: -I/home/user/pytorch/torch/include -I/home/user/pytorch/torch/include/torch/csrc/api/include ... Update PCH handling to work with list of paths instead of include directives. This change fixes most tests in test/inductor/test_cpp_wrapper.py on s390x.
AlekseiNikiforovIBM
force-pushed
the
s390x_inductor_support
branch
from
dc3479e
to
299a590
Compare
AlekseiNikiforovIBM
requested review from
fmassa,
soumith and
ezyang
as code owners
ezyang
reviewed
Oct 20, 2023
| @@ -1048,7 +1064,7 @@ def get_include_and_linking_paths( | |||
| vec_isa: VecISA = invalid_vec_isa, | |||
| cuda: bool = False, | |||
| aot_mode: bool = False, | |||
| ) -> Tuple[str, str, str, str]: | |||
| ) -> Tuple[Any, str, str, str, str]: | |||
There was a problem hiding this comment.
No, it's a list of strings.
There was a problem hiding this comment.
List[str] then, pretty please? :)
ezyang
approved these changes
Oct 20, 2023
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 23, 2023
Follow up to #111367 Pull Request resolved: #111793 Approved by: https://github.com/ezyang, https://github.com/Skylion007
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Oct 26, 2023
Use arch compile flags. They are needed for vectorization support on s390x. Implement new helper functions for inductor. This change fixes multiple tests in test_cpu_repro.py Pull Request resolved: pytorch#111367 Approved by: https://github.com/ezyang
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Oct 26, 2023
Follow up to pytorch#111367 Pull Request resolved: pytorch#111793 Approved by: https://github.com/ezyang, https://github.com/Skylion007
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Use arch compile flags. They are needed for vectorization support on s390x. Implement new helper functions for inductor. This change fixes multiple tests in test_cpu_repro.py Pull Request resolved: pytorch#111367 Approved by: https://github.com/ezyang
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Follow up to pytorch#111367 Pull Request resolved: pytorch#111793 Approved by: https://github.com/ezyang, https://github.com/Skylion007
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Follow up to pytorch#111367 Pull Request resolved: pytorch#111793 Approved by: https://github.com/ezyang, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use arch compile flags. They are needed for vectorization support on s390x.
Implement new helper functions for inductor.
This change fixes multiple tests in test_cpu_repro.py
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler