New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nvfuser code base nuke #111447
Nvfuser code base nuke #111447
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111447
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 34e2881 with merge base 2f09da3 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I don't think failing tests are relevant. I'm gonna wait until |
This is breaking the 2k LOC sanity check. But it's just removing dead code. Can we make an exception on that here, otherwise, it's going to be a ~85 PRs. 😆 cc'ing @malfet Meanwhile, since I'm removing some bazel build files, would you mind try import and run this? @davidberard98 |
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@jjsjann123 i'm fine with ignoring this check (also, let me modify it to never fire up if total is net negative) |
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yes completely fine to skip this! |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/6662910163 |
@jjsjann123 can you do the manual rebase please? |
merged |
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pytorchbot rebase -s |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/6706601765 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidberard98 if this is too prone to merge conflicts, it might be simpler to rebase + insta merge yourself.
The merge conflicts should be pretty clear.
Let me do manual rebase. |
merged |
thanks! (btw, I'm kind of confused why the automated rebase didn't work; test_gpu3.cpp doesn't seem like it has changed since your last manual merge?) |
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Indeed! There's no merge conflict when I just merged to upstream/viable/strict. But this isn't the first time with a false merge conflict from the bot. |
CI failure looks mysterious. The import did happen after my last rebase.
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
removing nvfuser code base. Pull Request resolved: pytorch#111447 Approved by: https://github.com/albanD
removing nvfuser code base. Pull Request resolved: pytorch#111447 Approved by: https://github.com/albanD
removing nvfuser code base. Pull Request resolved: pytorch#111447 Approved by: https://github.com/albanD
removing nvfuser code base.
cc @albanD