[quant][pt2e][be] Cleanup observer insertion logic #111828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111828
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 78c7740 with merge base d22e5e4 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Oct 23, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 776cb5fcc8fba7273b2054d0a065679fee346cbf Pull Request resolved: #111828
jerryzh168
requested review from
kimishpatel,
andrewor14 and
leslie-fang-intel
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 23, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 51b8bd28b260bc552184c760775ba37a5b7f59a9 Pull Request resolved: #111828
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 23, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 10558a74d77ed81875be444cb6b55d143c70c0ea Pull Request resolved: #111828
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 24, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7d4e646a3a948924235ca91d9667b9602473df8c Pull Request resolved: #111828
kimishpatel
approved these changes
Oct 24, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Oct 26, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111828 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#111827
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@jerryzh168 your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 27, 2023
This reverts commit bf998a2. Reverted #111828 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#111828 (comment)))
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Oct 31, 2023
…11828) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 31, 2023
…112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: #112453 Approved by: https://github.com/andrewor14
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111828 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#111827
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…11828)" This reverts commit bf998a2. Reverted pytorch#111828 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#111828 (comment)))
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…11828) (pytorch#112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: pytorch#112453 Approved by: https://github.com/andrewor14
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: python test/test_quantization.py TestQuantizePT2E CIs Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#111828 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#111827
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…11828)" This reverts commit bf998a2. Reverted pytorch#111828 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#111828 (comment)))
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…11828) (pytorch#112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: pytorch#112453 Approved by: https://github.com/andrewor14
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Nov 19, 2023
…11828)" This reverts commit bf998a2. Reverted pytorch#111828 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#111828 (comment)))
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Nov 19, 2023
…11828) (pytorch#112453) Summary: att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bf998a2c5d549cf4856c7becfca4a169bf68b709 Test plan from GitHub: python test/test_quantization.py TestQuantizePT2E CIs Differential Revision: D50816224 Pulled By: jerryzh168 Pull Request resolved: pytorch#112453 Approved by: https://github.com/andrewor14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
att, after SharedQuantizationSpec bug fix we are doing some checks before hand, this can simplify the logic when we insert observers
Test Plan:
python test/test_quantization.py TestQuantizePT2E
CIs
Reviewers:
Subscribers:
Tasks:
Tags: