New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'BaseOutput' and subclasses from 'diffusers' in dynamo #111978
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111978
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8362bed with merge base e36daca (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
ghstack-source-id: 54caa08e6df8542af8316624fc05782ef73b59b2 Pull Request resolved: #111978
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
ghstack-source-id: 0799c2f6c57688c320df0cce66a0c54c9686fb00 Pull Request resolved: #111978
@jansel PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failing?
There are some weird segfaults happening in CI, I'm trying to debug. So far I cannot repro on my end, but it seems consistent on CI machines. |
… from 'diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
ghstack-source-id: 6548b7cd6fd1a60b65eb6bef7afd8a6c6bc0a145 Pull Request resolved: #111978
ghstack-source-id: 6548b7cd6fd1a60b65eb6bef7afd8a6c6bc0a145 Pull Request resolved: #111978
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command
Details for Dev Infra teamRaised by workflow job |
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
ghstack-source-id: 914e0a4c83ff2561ef36e386d39e0ab35e6a9600 Pull Request resolved: #111978
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ch#111978) Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: pytorch#111978 Approved by: https://github.com/jansel
…ch#111978) Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: pytorch#111978 Approved by: https://github.com/jansel
…ch#111978) Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: pytorch#111978 Approved by: https://github.com/jansel
Stack from ghstack (oldest at bottom):
Extending the workarounds for
transformers
ModelOutput
to coverdiffusers
BaseOutput
. Together with huggingface/diffusers#5459 it should unblock export fordiffusers
models.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng