[dtensor] enable foreach operators for adam optimizer #112108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc @awgu [ghstack-poisoned]
wanchaol
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu and
kwen2501
as code owners
wanchaol
requested review from
fegin,
fduwjj,
wz337,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112108
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e17ac89 with merge base 08dbfec ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wanchaol
added a commit
that referenced
this pull request
Oct 26, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc awgu ghstack-source-id: bf89d590477fe43dc8f00220ac9713e3c775a442 Pull Request resolved: #112108
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc awgu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Oct 30, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc awgu ghstack-source-id: d4e77bc5939eb6955f536c906ef874a51c4f6dc6 Pull Request resolved: #112108
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. Some latency measurement, on a 5-layer MLP model: single tensor adam: 17ms  foreach multitensor adam: 4ms  so around 4.25x improvement cc awgu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Oct 30, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc awgu ghstack-source-id: 99df084c81043d803a6a18f82dd924ed5dc88096 Pull Request resolved: #112108
wanchaol
added
the
ciflow/periodic
XilunWu
reviewed
Oct 31, 2023
XilunWu
reviewed
Oct 31, 2023
XilunWu
reviewed
Oct 31, 2023
XilunWu
reviewed
Oct 31, 2023
XilunWu
reviewed
Oct 31, 2023
XilunWu
reviewed
Oct 31, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
wanchaol
added a commit
that referenced
this pull request
Oct 31, 2023
As titled. cc @XilunWu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Oct 31, 2023
As titled. cc XilunWu ghstack-source-id: 875fb91d4e8dbe9e34718f9df86715ec41981923 Pull Request resolved: #112472
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. Some latency measurement, on a 5-layer MLP model: single tensor adam: 17ms  foreach multitensor adam: 4ms  so around 4.25x improvement cc awgu [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Oct 31, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. cc awgu ghstack-source-id: b37c497620b9b15895bbe997c4774e601b2bf9fd Pull Request resolved: #112108
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@wanchaol What is the technical complexity to further enable fused Adam? |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. Some latency measurement, on a 5-layer MLP model: single tensor adam: 17ms  foreach multitensor adam: 4ms  so around 4.25x improvement Pull Request resolved: pytorch#112108 Approved by: https://github.com/wz337
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. Some latency measurement, on a 5-layer MLP model: single tensor adam: 17ms  foreach multitensor adam: 4ms  so around 4.25x improvement Pull Request resolved: pytorch#112108 Approved by: https://github.com/wz337
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Nov 19, 2023
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance compare to optimizer using torch.Tensor. Currently by default optimizer won't do this for tensor subclass, we will need to enable this by default in DTensor when all ops are covered, or early enable this when exploring new FSDP, we just need to append DTensor to the optimizer allow list. Some latency measurement, on a 5-layer MLP model: single tensor adam: 17ms  foreach multitensor adam: 4ms  so around 4.25x improvement Pull Request resolved: pytorch#112108 Approved by: https://github.com/wz337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR enables basic foreach ops in DTensor for adam optimizer, to improve performance
compare to optimizer using torch.Tensor. Currently by default optimizer
won't do this for tensor subclass, we will need to enable this by
default in DTensor when all ops are covered, or early enable this when
exploring new FSDP, we just need to append DTensor to the optimizer
allow list.
Some latency measurement, on a 5-layer MLP model:
single tensor adam: 17ms
foreach multitensor adam: 4ms
so around 4.25x improvement
cc @awgu