Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Half support for poisson and use float for Half cumulative distribution on CPU #112124

Closed
wants to merge 2 commits into from
Closed

Add Half support for poisson and use float for Half cumulative distribution on CPU #112124

wants to merge 2 commits into from

Conversation

CaoE
Copy link
Collaborator

@CaoE CaoE commented Oct 26, 2023 •
edited by pytorch-bot bot

Add Half support for poisson and use float for Half cumulative distribution on CPU

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112124

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f91eb43 with merge base 64f3260 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 26, 2023
@CaoE CaoE added ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor topic: not user facing topic category module: half Related to float16 half-precision floats labels Oct 26, 2023
@CaoE CaoE marked this pull request as ready for review October 29, 2023 06:32
@CaoE CaoE mentioned this pull request Oct 30, 2023
Closed
@CaoE CaoE requested a review from cpuhrsch October 30, 2023 01:47
cpuhrsch
cpuhrsch requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test for the extended functionality

@CaoE
Copy link
Collaborator Author

CaoE commented Oct 30, 2023 •
edited

@cpuhrsch Added Half tests for poisson and there are already Half tests for multinomial https://github.com/pytorch/pytorch/blob/main/test/test_torch.py#L5003.

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2023
@cpuhrsch
Copy link
Contributor

Hm, @CaoE - if the test already exists (and presumably runs and succeeds?) then I'm surprised that we stiil need to add coverage for it? Can I ask you to check whether it already runs? Maybe this change already happened? I want to avoid potentially having multiple implementations for the same op + device + dtype combo.

@CaoE
Copy link
Collaborator Author

CaoE commented Oct 31, 2023

@cpuhrsch It already runs. Half support for multinomial is added by #104178. This PR is not to add Half support for multinomial. It uses float for Half (like bfloat16) to cumulate.

@CaoE
Copy link
Collaborator Author

CaoE commented Nov 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@CaoE @xuhancn
Add Half support for poisson and use float for Half cumulative distri…
6a17213 
…bution on CPU (pytorch#112124)

Add Half support for poisson and use float for Half cumulative distribution on CPU

Pull Request resolved: pytorch#112124
Approved by: https://github.com/cpuhrsch
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@CaoE @Skylion007
Add Half support for poisson and use float for Half cumulative distri…
ba2dc83 
…bution on CPU (pytorch#112124)

Add Half support for poisson and use float for Half cumulative distribution on CPU

Pull Request resolved: pytorch#112124
Approved by: https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats open source release notes: intel release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CaoE @cpuhrsch @pytorchmergebot @zou3519 @pytorchbot