Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU #112132

Closed
wants to merge 1 commit into from

Conversation

CaoE
Copy link
Collaborator

@CaoE CaoE commented Oct 26, 2023

Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Oct 26, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112132

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit bccbab0 with merge base 64f3260 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 26, 2023
@CaoE CaoE added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request module: half Related to float16 half-precision floats ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Oct 26, 2023
@CaoE CaoE force-pushed the fp16_ops3 branch 3 times, most recently from 1cab21a to d40bf38 Compare October 29, 2023 06:31
@CaoE CaoE requested a review from cpuhrsch October 30, 2023 01:47
@CaoE CaoE marked this pull request as ready for review October 30, 2023 01:50
@CaoE
Copy link
Collaborator Author

CaoE commented Oct 31, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch rebase origin/main returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/test_mps.py
CONFLICT (content): Merge conflict in test/test_mps.py
Auto-merging test/test_reductions.py
Auto-merging torch/testing/_internal/common_methods_invocations.py
Auto-merging torch/testing/_internal/opinfo/definitions/_masked.py
error: could not apply 1a5df2a9f8b... Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU (#112132)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 1a5df2a9f8b... Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU (#112132)
Details for Dev Infra team Raised by workflow job

@cpuhrsch cpuhrsch added topic: new features topic category topic: improvements topic category and removed topic: not user facing topic category topic: new features topic category labels Oct 31, 2023
@cpuhrsch
Copy link
Contributor

@CaoE - The topic for these changes should be "improvements". They every much are user facing since they extend operator coverage to a new dtype on a device. Please update the other PRs as well.

@cpuhrsch cpuhrsch added the release notes: nn release notes category label Oct 31, 2023
@CaoE
Copy link
Collaborator Author

CaoE commented Nov 1, 2023

@cpuhrsch Do other PRs also require release note: nn ?

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 1, 2023

@CaoE - I'm not sure. We could also use "release notes: intel". Seems appropriate?

@CaoE
Copy link
Collaborator Author

CaoE commented Nov 3, 2023

@cpuhrsch I added a new label "release notes: half" for half support.

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 3, 2023

@CaoE - Please use an existing label and delete the one you created. It won't work with our release notes setup. I think release notes: intel is appropriate.

@CaoE CaoE added release notes: intel release notes category and removed release notes: half release notes: nn release notes category labels Nov 3, 2023
@CaoE
Copy link
Collaborator Author

CaoE commented Nov 3, 2023

@cpuhrsch Removed & deleted release notes: half and use release notes: intel instead.d

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 3, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fp16_ops3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fp16_ops3 && git pull --rebase)

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 3, 2023

@pytrchbot merge

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 3, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fp16_ops3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fp16_ops3 && git pull --rebase)

@CaoE
Copy link
Collaborator Author

CaoE commented Nov 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
…on CPU (pytorch#112132)

Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU.

Pull Request resolved: pytorch#112132
Approved by: https://github.com/cpuhrsch
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
…on CPU (pytorch#112132)

Add Half support for cummax, cummin, cumprod, logcumsumexp, and prod on CPU.

Pull Request resolved: pytorch#112132
Approved by: https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats open source release notes: intel release notes category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants