[Dist] Add fallback reduce_scatter_base, allgather_base APIs to Gloo #112144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to enable FSDP on CPUs Differential Revision: [D50636382](https://our.internmc.facebook.com/intern/diff/D50636382/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung,
d4l3k and
wz337
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112144
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 87c691b with merge base dd24e92 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (c10d)
This was referenced Oct 26, 2023
fegin
approved these changes
Oct 27, 2023
wanchaol
approved these changes
Oct 27, 2023
| @@ -1919,6 +1919,38 @@ class AsyncAllgatherCUDAWork : public AsyncAllgatherWork { | |||
|
|
|||
| } // namespace | |||
|
|
|||
| c10::intrusive_ptr<Work> ProcessGroupGloo::_reduce_scatter_base( | |||
There was a problem hiding this comment.
Nice, maybe worth removing those fallbacks in the functional collective paths and this might help testing https://github.com/pytorch/pytorch/blob/main/torch/distributed/_functional_collectives_impl.py#L180
XilunWu
approved these changes
Oct 31, 2023
…Is to Gloo" Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to enable FSDP on CPUs Differential Revision: [D50636382](https://our.internmc.facebook.com/intern/diff/D50636382/) [ghstack-poisoned]
…Is to Gloo" Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to enable FSDP on CPUs Differential Revision: [D50636382](https://our.internmc.facebook.com/intern/diff/D50636382/) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 7, 2023
Differential Revision: [D50688958](https://our.internmc.facebook.com/intern/diff/D50688958/) Pull Request resolved: #112145 Approved by: https://github.com/fegin ghstack dependencies: #112144
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ytorch#112144) Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to enable FSDP on CPUs Differential Revision: [D50636382](https://our.internmc.facebook.com/intern/diff/D50636382/) Pull Request resolved: pytorch#112144 Approved by: https://github.com/wz337, https://github.com/fegin, https://github.com/wanchaol, https://github.com/XilunWu
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Differential Revision: [D50688958](https://our.internmc.facebook.com/intern/diff/D50688958/) Pull Request resolved: pytorch#112145 Approved by: https://github.com/fegin ghstack dependencies: pytorch#112144
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ytorch#112144) Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to enable FSDP on CPUs Differential Revision: [D50636382](https://our.internmc.facebook.com/intern/diff/D50636382/) Pull Request resolved: pytorch#112144 Approved by: https://github.com/wz337, https://github.com/fegin, https://github.com/wanchaol, https://github.com/XilunWu
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Differential Revision: [D50688958](https://our.internmc.facebook.com/intern/diff/D50688958/) Pull Request resolved: pytorch#112145 Approved by: https://github.com/fegin ghstack dependencies: pytorch#112144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Per Ke's suggestion, adding these APIs in ProcessGroupGloo directly to
enable FSDP on CPUs
Differential Revision: D50636382