Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing in dynamic_shapes without original argument name #112298

Closed
wants to merge 3 commits into from
Closed

Allow passing in dynamic_shapes without original argument name #112298

wants to merge 3 commits into from

Conversation

tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Oct 27, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112298

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3fda213 with merge base 5a6f801 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

tugsbayasgalan added a commit that referenced this pull request Oct 27, 2023
@tugsbayasgalan
Allow passing in dynamic_shapes without original argument name
be2f741 
ghstack-source-id: 66b197bcb9c4b811a8f5b332b36fa092f3e17691
Pull Request resolved: #112298
avikchaudhuri
avikchaudhuri requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@avikchaudhuri avikchaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to not have dict matching tuple recursively, because this is not pytree-friendly. Instead we're merely making a decision on how to bind the top-level structure of dynamic shapes to the top-level structure of the signature.

test/export/test_export.py Outdated Show resolved Hide resolved
torch/_export/__init__.py Outdated Show resolved Hide resolved
torch/_export/__init__.py Outdated Show resolved Hide resolved
torch/export/__init__.py Outdated Show resolved Hide resolved
torch/_export/__init__.py Outdated Show resolved Hide resolved
@tugsbayasgalan
Update on "Allow passing in dynamic_shapes without original argument …
5069019 
…name"

cc avikchaudhuri gmagogsfm zhxchen17 angelayi

[ghstack-poisoned]
tugsbayasgalan added a commit that referenced this pull request Oct 30, 2023
@tugsbayasgalan
Allow passing in dynamic_shapes without original argument name
1d29f14 
ghstack-source-id: 6770d88fa77bd8ce424037b0c7afaa32d2d74cfd
Pull Request resolved: #112298
@tugsbayasgalan tugsbayasgalan added topic: new features topic category ciflow/trunk Trigger trunk jobs on your pull request labels Oct 31, 2023
@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 1d29f1455cd783f95fddf080fb7cdee92dcaf262 returned non-zero exit code 1

Auto-merging test/export/test_export.py
Auto-merging torch/_export/__init__.py
CONFLICT (content): Merge conflict in torch/_export/__init__.py
Auto-merging torch/export/__init__.py
CONFLICT (content): Merge conflict in torch/export/__init__.py
error: could not apply 1d29f1455cd... Allow passing in dynamic_shapes without original argument name
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@tugsbayasgalan
Update on "Allow passing in dynamic_shapes without original argument …
3fda213 
…name"

cc avikchaudhuri gmagogsfm zhxchen17 angelayi suo

[ghstack-poisoned]
tugsbayasgalan added a commit that referenced this pull request Nov 1, 2023
@tugsbayasgalan
Allow passing in dynamic_shapes without original argument name
a2df596 
ghstack-source-id: 44bd5d782550868bcfbde0280d2e22435ca9d1ea
Pull Request resolved: #112298
@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/tugsbayasgalan/164/head branch November 5, 2023 15:26
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@tugsbayasgalan @xuhancn
Allow passing in dynamic_shapes without original argument name (pytor…
48bdcc2 
…ch#112298)

Pull Request resolved: pytorch#112298
Approved by: https://github.com/avikchaudhuri
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@tugsbayasgalan @Skylion007
Allow passing in dynamic_shapes without original argument name (pytor…
8744293 
…ch#112298)

Pull Request resolved: pytorch#112298
Approved by: https://github.com/avikchaudhuri
andreigh pushed a commit to andreigh/pytorch that referenced this pull request Nov 19, 2023
@tugsbayasgalan @andreigh
Allow passing in dynamic_shapes without original argument name (pytor…
02706dd 
…ch#112298)

Pull Request resolved: pytorch#112298
Approved by: https://github.com/avikchaudhuri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tugsbayasgalan @pytorchmergebot @avikchaudhuri